[libc++][TZDB] Makes implementation experimental. #95657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) ChangesThis moves the files to libcxx/src/experimental/ as discussed in #90394. Fixes: #94902 Full diff: https://github.com/llvm/llvm-project/pull/95657.diff 9 Files Affected:
diff --git a/libcxx/src/CMakeLists.txt b/libcxx/src/CMakeLists.txt
index 9e6c70335a794..9453715636b44 100644
--- a/libcxx/src/CMakeLists.txt
+++ b/libcxx/src/CMakeLists.txt
@@ -336,16 +336,16 @@ endif()
if (LIBCXX_ENABLE_LOCALIZATION AND LIBCXX_ENABLE_FILESYSTEM AND LIBCXX_ENABLE_TIME_ZONE_DATABASE)
list(APPEND LIBCXX_EXPERIMENTAL_SOURCES
- include/tzdb/time_zone_private.h
- include/tzdb/types_private.h
- include/tzdb/tzdb_list_private.h
- include/tzdb/tzdb_private.h
+ experimental/include/tzdb/time_zone_private.h
+ experimental/include/tzdb/types_private.h
+ experimental/include/tzdb/tzdb_list_private.h
+ experimental/include/tzdb/tzdb_private.h
# TODO TZDB The exception could be moved in chrono once the TZDB library
# is no longer experimental.
- chrono_exception.cpp
- time_zone.cpp
- tzdb.cpp
- tzdb_list.cpp
+ experimental/chrono_exception.cpp
+ experimental/time_zone.cpp
+ experimental/tzdb.cpp
+ experimental/tzdb_list.cpp
)
endif()
diff --git a/libcxx/src/chrono_exception.cpp b/libcxx/src/experimental/chrono_exception.cpp
similarity index 100%
rename from libcxx/src/chrono_exception.cpp
rename to libcxx/src/experimental/chrono_exception.cpp
diff --git a/libcxx/src/include/tzdb/time_zone_private.h b/libcxx/src/experimental/include/tzdb/time_zone_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/time_zone_private.h
rename to libcxx/src/experimental/include/tzdb/time_zone_private.h
diff --git a/libcxx/src/include/tzdb/types_private.h b/libcxx/src/experimental/include/tzdb/types_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/types_private.h
rename to libcxx/src/experimental/include/tzdb/types_private.h
diff --git a/libcxx/src/include/tzdb/tzdb_list_private.h b/libcxx/src/experimental/include/tzdb/tzdb_list_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/tzdb_list_private.h
rename to libcxx/src/experimental/include/tzdb/tzdb_list_private.h
diff --git a/libcxx/src/include/tzdb/tzdb_private.h b/libcxx/src/experimental/include/tzdb/tzdb_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/tzdb_private.h
rename to libcxx/src/experimental/include/tzdb/tzdb_private.h
diff --git a/libcxx/src/time_zone.cpp b/libcxx/src/experimental/time_zone.cpp
similarity index 100%
rename from libcxx/src/time_zone.cpp
rename to libcxx/src/experimental/time_zone.cpp
diff --git a/libcxx/src/tzdb.cpp b/libcxx/src/experimental/tzdb.cpp
similarity index 100%
rename from libcxx/src/tzdb.cpp
rename to libcxx/src/experimental/tzdb.cpp
diff --git a/libcxx/src/tzdb_list.cpp b/libcxx/src/experimental/tzdb_list.cpp
similarity index 100%
rename from libcxx/src/tzdb_list.cpp
rename to libcxx/src/experimental/tzdb_list.cpp
|
mordante
force-pushed
the
review/renames_tzdb_files
branch
from
c8e5438
to
5e08f6b
Compare
ldionne
approved these changes
Jun 18, 2024
This moves the files to libcxx/src/experimental/ as discussed in llvm#90394. Fixes: llvm#94902
mordante
force-pushed
the
review/renames_tzdb_files
branch
from
5e08f6b
to
cbe55b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the files to libcxx/src/experimental/ as discussed in #90394.
Fixes: #94902